Merged
Conversation
이력서 수정 고도화 예비책으로, 만약 드래그 된 부분에 해당하는 키값 찾는 로직
IlMinCho
approved these changes
Dec 1, 2024
Member
IlMinCho
left a comment
IlMinCho
left a comment
There was a problem hiding this comment.
형 고생하셨어요 전반적으로 훑어봣는데 제가 해논 형식 전부 이해하신거 같아서 보기좋습니다. 멋져요 ㅋㅋㅋㅋ
요청시간이나, 이런거 개선필요한지 체크해보시고 여러 시나리오만들어서 QA하면서 개선할부분들 찾아내면 될거같네요 굿
Comment on lines
+283
to
+288
| "role": "system", | ||
| "content": ( | ||
| "You are a friendly and professional resume modification expert." | ||
| "Your task is to update only the specified sections of the resume based on the user's request while leaving all other parts unchanged." | ||
| "Ensure the modifications are concise, professional, and aligned with the tone of the original resume." | ||
| ) |
Member
There was a problem hiding this comment.
프롬프트 작성한건 잘 작성하신거같아요
이 부분은 정확한 정답이 없다보니, 이것저것 일반적인 상황들 넣어서 테스트해보고, 엣지케이스들도 넣어서 테스트하면서
결과값들을 보면서 잘나오는지 확인하는게 방법인거같아요.
저 방식대로 점점 개선해나가면 될겁니다. :)
Comment on lines
+1
to
+48
| from pydantic import BaseModel | ||
| from typing import List, Optional | ||
|
|
||
| class WorkExperience(BaseModel): | ||
| companyName: str | ||
| departmentName: str | ||
| role: str | ||
| workType: str # FULL_TIME, PART_TIME 등 | ||
| employmentStatus: str # EMPLOYMENT, UNEMPLOYMENT 등 | ||
| startedAt: str # YYYY-MM 형식 | ||
| endedAt: Optional[str] # YYYY-MM 형식 또는 빈 값 | ||
|
|
||
| class ProjectResponse(BaseModel): | ||
| projectName: str | ||
| projectStartedAt: str # YYYY.MM 형식 | ||
| projectEndedAt: str # YYYY.MM 형식 | ||
| skillSet: str | ||
| projectDescription: str | ||
| repoLink: str | ||
| class Link(BaseModel): | ||
| linkTitle: str | ||
| linkUrl: str | ||
|
|
||
| class Education(BaseModel): | ||
| schoolType: str # UNIVERSITY_BACHELOR 등 | ||
| schoolName: str | ||
| major: str | ||
| graduationStatus: str # ATTENDING, GRADUATED 등 | ||
| startedAt: str # YYYY-MM 형식 | ||
| endedAt: Optional[str] # YYYY-MM 형식 또는 빈 값 | ||
|
|
||
| class Certificate(BaseModel): | ||
| certificateName: str | ||
| certificateGrade: str | ||
| certificatedAt: str # YYYY-MM 형식 | ||
| certificateOrganization: str | ||
|
|
||
| class ResumeResponseDto(BaseModel): | ||
| resumeId: str | ||
| memberId: int | ||
| memberName: str | ||
| avatarUrl: str | ||
| email: str | ||
| position: str | ||
| techStack: List[str] | ||
| aboutMe: str | ||
| tags: Optional[List[str]] # null 가능 | ||
| workExperiences: List[WorkExperience] |
Member
There was a problem hiding this comment.
dto도 멋진데요? ㅎㅎ 리턴하고 요청받는것만 약속한대로 유지하고, 나머지는 형이 편한대로 잘짜시면되요 보기에는 문제가 없어보입니다. :) 굿
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
📝작업 내용
스크린샷 (선택)
💬리뷰 요구사항(선택)